Remove calls to test APIs unavailable in jdk17u #30
Conversation
|
How was this issue discovered? |
The test failed in the release pipeline. I missed this in the backport because I mistakenly attributed this to a jtreg version issue. |
|
The backport used the jdk21u APIs introduced in openjdk/jdk21u@262cacb#diff-13897cfb2b23f2a1424c9874bdb40f563b56cd01d2b560ace927fe240d15a5a9 and should have used the previous OutputAnalyzer. |
| @@ -115,7 +120,7 @@ private static boolean getSchedulesAllProcessorGroups(boolean isWindowsServer) t | |||
| private static OutputAnalyzer getAvailableProcessorsOutput(boolean productFlagEnabled) throws IOException { | |||
| String productFlag = productFlagEnabled ? "-XX:+UseAllWindowsProcessorGroups" : "-XX:-UseAllWindowsProcessorGroups"; | |||
|
|
|||
| ProcessBuilder processBuilder = ProcessTools.createLimitedTestJavaProcessBuilder( | |||
| ProcessBuilder processBuilder = ProcessTools.createJavaProcessBuilder( | |||
There was a problem hiding this comment.
Is this change also related to something that exists in 21 but isn't available in 17?
There was a problem hiding this comment.
Is this change also related to something that exists in 21 but isn't available in 17?
Yes, jdk17u didn't have the fix for https://bugs.openjdk.org/browse/JDK-8315097 (although that is now being backported to jdk17u for the next release so we'll pick up that update automatically).
swesonga
merged commit 4babac7
into
ms-patches/use-all-windows-processor-groups
Some of the usage of the OutputAnalyzer in the TestAvailableProcessors class depends on APIs that are not in the jdk17u OutputAnalyzer. This PR cleans up these issues that prevent the class from compiling in jdk17u.