TraceParserGen: Fix task guids and RegisterTemplate. #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Task class and keep instances in m_tasks dictionary instead of m_taskNames, m_taskValues and potential m_taskGuids. Generate guids variables or pass Guid.Empty Add basic RegisterTemplate implementation. fix microsoft#1351
|
Pull #1406 from oatkins targets similar issues. |
|
LGTM :-) |
inthemedium
reviewed
May 16, 2023
| @@ -314,6 +328,12 @@ private void GenerateTemplateDefs(TextWriter output) | |||
| output.WriteLine(" callback(template);"); | |||
| output.WriteLine(" }"); | |||
| output.WriteLine(); | |||
|
|
|||
| output.WriteLine(" private void RegisterTemplate(TraceEvent template)"); | |||
There was a problem hiding this comment.
I guess this is a compromise between the previous style and the current style. Personally, I like the current style, which omits this private method call but it isn't any different in practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Task class and keep instances in m_tasks dictionary
instead of m_taskNames, m_taskValues and potential m_taskGuids.
Generate guids variables or pass Guid.Empty
Add basic RegisterTemplate implementation.
fix #1351