Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): Add VFP counter metric for uninitialized object #958

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BeegiiK
Copy link
Contributor

@BeegiiK BeegiiK commented Nov 6, 2024

Description

Add node level metric for no VFPCounters. Tested the new metric works by calling the metrics endpoint inside the node of the windows retina pod:

curl.exe http://10.224.0.9:10093/metrics  

...
# HELP networkobservability_windows_hns_stats Include many different metrics from packets sent/received to closed connections
# TYPE networkobservability_windows_hns_stats gauge
networkobservability_windows_hns_stats{direction="win_packets_recv_count"} 12
networkobservability_windows_hns_stats{direction="win_packets_sent_count"} 84
# HELP networkobservability_windows_vfp_stats Include many different metrics from packets sent/received to closed connections
# TYPE networkobservability_windows_vfp_stats gauge
networkobservability_windows_vfp_stats{state="uninitialized"} 36

Related Issue

#933

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

The metric was generated as it brought outside the conditional statement for testing purposes only, i.e. metric can be compiled and incremented.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@BeegiiK BeegiiK requested a review from a team as a code owner November 6, 2024 16:23
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/types.go Outdated Show resolved Hide resolved
matmerr
matmerr previously approved these changes Nov 21, 2024
@BeegiiK BeegiiK force-pushed the issues/993 branch 5 times, most recently from 171324f to e0bb58a Compare November 22, 2024 11:28
kamilprz
kamilprz previously approved these changes Nov 22, 2024
Copy link

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label Dec 23, 2024
@BeegiiK BeegiiK dismissed stale reviews from kamilprz and matmerr via 853c0e7 December 23, 2024 10:04
@github-actions github-actions bot removed the meta/waiting-for-author Blocked and waiting on the author label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants