Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: .Net: Add function calling with AzureAIInference sample #9954

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Python: .Net: Add function calling with AzureAIInference sample #9954

wants to merge 5 commits into from
+100 −10

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Closes #9933

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner December 12, 2024 12:46
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Dec 12, 2024
@github-actions github-actions bot changed the title Add function calling with AzureAIInference sample .Net: Add function calling with AzureAIInference sample Dec 12, 2024
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_9933 branch from a99fc59 to 1cdd401 Compare December 12, 2024 12:49
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner December 12, 2024 12:49
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Dec 12, 2024
@github-actions github-actions bot changed the title .Net: Add function calling with AzureAIInference sample Python: .Net: Add function calling with AzureAIInference sample Dec 12, 2024
@markwallace-microsoft markwallace-microsoft mentioned this pull request Dec 12, 2024
Open
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_9933 branch from 1cdd401 to 4777012 Compare December 12, 2024 13:49
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_9933 branch from 4777012 to 717ccfe Compare December 12, 2024 13:52
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Dec 16, 2024
markwallace-microsoft
markwallace-microsoft commented Dec 16, 2024
View reviewed changes
...c/Connectors/Connectors.AzureAIInference/Settings/AzureAIInferencePromptExecutionSettings.cs
private IList<string> _stopSequences = [];
private IList<ChatCompletionsToolDefinition> _tools = [];
private IList<string>? _stopSequences;
private IList<ChatCompletionsToolDefinition>? _tools;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialising tools to an empty array causes a Problem in the JSON payload.

@RogerBarreto Is there a reason why this is being initialised to an empty array?

moonbox3
moonbox3 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Python concept sample typo fix. Thanks @markwallace-microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonbox3 moonbox3 moonbox3 approved these changes

@dmytrostruk dmytrostruk dmytrostruk approved these changes

Assignees
No one assigned
Labels
documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Bug: Azure-hosted Open-Source Models (e.g., Mistral Nemo) fail with Kernel Functions in .NET
3 participants
@markwallace-microsoft @dmytrostruk @moonbox3