http-client-java, refactor crossLanguageDefinitionId #5429
Merged
+537
−577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
XiaofeiCao
approved these changes
Dec 23, 2024
|
You can try these changes here
|
weidongxu-microsoft
requested review from
srnagar and
haolingdong-msft
as code owners
weidongxu-microsoft
deleted the
http-client-java_refactor-crossLanguageDefinitionId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-model, move it to
LanguageVisible effect is that sync/async client should now have a crossLanguageDefinitionId.
e.g.
Previous, it is null, e.g.
https://github.com/allenjzhang/typespec-e2e-demo/blob/main/todoApp/clients/java/src/main/resources/META-INF/todo_apiview_properties.json#L25
PS: should it be
nullinstead of"null"?