Dimm WCO when dialog opens #236080
Open
Dimm WCO when dialog opens #236080
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Dec 16, 2024
| @@ -33,11 +36,14 @@ export class DialogHandlerContribution extends Disposable implements IWorkbenchC | |||
| @IKeybindingService keybindingService: IKeybindingService, | |||
| @IInstantiationService instantiationService: IInstantiationService, | |||
| @IProductService productService: IProductService, | |||
| @IClipboardService clipboardService: IClipboardService | |||
| @IClipboardService clipboardService: IClipboardService, | |||
| @INativeHostService nativeHostService: INativeHostService, | |||
There was a problem hiding this comment.
Native host service is Electron only, not web.
| const overlayColor = new Color(new RGBA(0, 0, 0, 0.3)); | ||
| const backgroundColor = dimmed ? overlayColor.makeOpaque(titleBarBackgroundColor) : titleBarBackgroundColor; | ||
| const foregroundColor = dimmed ? overlayColor.makeOpaque(titleBarForegroundColor) : titleBarForegroundColor; | ||
|
|
There was a problem hiding this comment.
Is this taken from somewhere were we already dim buttons or is this new? We still have custom window buttons around here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dimming of window controls when a dialog is open and updates the colors of the window controls based on the windows active state.
fixes #159671