Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifests: ykhwong.DOSBoxSVN-Daum version 20150125 #157185

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update manifests: ykhwong.DOSBoxSVN-Daum version 20150125 #157185

merged 1 commit into from
Jun 12, 2024

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jun 9, 2024 •
edited by microsoft-github-policy-service bot
Loading

Details

  • Add ARP entries of the package
  • This may prevent it from an infinite upgrade loop

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
Update manifests: ykhwong.DOSBoxSVN-Daum version 20150125
06a966e 
- Add ARP entries of the package
- This may prevent it from an infinite upgrade loop

Signed-off-by: 是蓝兔哟～ <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

1 similar comment
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 9, 2024 14:45
@stephengillie
Copy link
Collaborator

stephengillie commented Jun 10, 2024 •
edited
Loading

Hi @Dragon1573,

This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.

(Automated response - build 884.)

Edit: DisplayVersion is important, both in preventing issues with other manifests, and also with preventing the "upgrade always available" situation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 10, 2024
@stephengillie stephengillie added the Highest-Version-Removal The PR removes the highest version of the package from the repository. label Jun 10, 2024
@Dragon1573
Copy link
Contributor Author

Should I "backports" these APR entries to previous versions? I can help creating PRs for them.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 11, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Jun 11, 2024 •
edited
Loading

Yes, that is a good idea. Thank you for your help.

@stephengillie stephengillie removed the Highest-Version-Removal The PR removes the highest version of the package from the repository. label Jun 12, 2024
@Dragon1573
Copy link
Contributor Author

@stephengillie - Sorry, inspecting all version of package identifier ykhwong.DOSBoxSVN-Daum, there's only version 20150125 available. It's the only available version in winget.

22:58:06 D:\...\winget-pkgs  [master ≡] 1.26s pwsh> komac list-versions --identifier ykhwong.DOSBoxSVN-Daum
20150125

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 3d8b2c5 into microsoft:master Jun 12, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 12, 2024
@Dragon1573 Dragon1573 deleted the issues/133464 branch June 12, 2024 15:43
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOSBoxSVN-Daum/20150125
3 participants
@Dragon1573 @wingetbot @stephengillie