mtkennerly.madamiru version 0.1.0

[mtkennerly]

Checklist for Pull Requests

• Have you signed the Contributor License Agreement?
• Is there a linked Issue?

Manifests

• Have you checked that there aren't other open pull requests for the same manifest update/change?
• This PR only modifies one (1) manifest
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.9 schema?

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[mtkennerly]

Hmm, the errors don't sound like anything related to my changes specifically:

##[error]1ES PT Error: Job 'ContentValidation' uses the release tasks ["AzureFunction@1","AzureFunction@1","AzureFunction@1"] but is not marked as a release job. Release tasks will soon be disallowed outside of release jobs. See [https://aka.***/1espt/custom-release-job](https://aka.%2A%2A%2A/1espt/custom-release-job)

I was expecting a runtime error if GStreamer wasn't available on the test system (missing DLL), but not sure what this is.

[stephengillie]

Manual Validation ended with:

2024-12-13 12:57:27.461 [FAIL] Installer failed security check. Url: https://github.com/mtkennerly/madamiru/releases/download/v0.1.0/madamiru-v0.1.0-win64.zip Result: 0x80004005 Property(S): ErrorDialog = ErrorDlg MSI (s) (B8:E8) [12:57:16:077]: Windows Installer installed the product. Product Name: GStreamer 1.0. Product Version: 1.24.10. Product Language: 1033. Manufacturer: GStreamer Project. Installation success or error status: 0.

(Automated response - build 904.)

[mtkennerly]

@stephengillie Could you please advise how I can resolve the security check?

For what it's worth, Madamiru does get a clean report on VirusTotal: https://www.virustotal.com/gui/url/48658a8c56573aa8aee2bb98fdf26ab95d5f31c01608d7d75b6f1839cd9f247a

[stephengillie]

The security check didn't recur.

Is a dependency missing?

[mtkennerly]

Yes, Madamiru depends on GStreamer ( https://gstreamer.freedesktop.org ), which the user is expected to install separately. I did specify the dependency in the manifest, but I think that's just for documentation purposes and not automatically installed, right? Is there any way to set up the test environment for this or bypass it?

Dependencies:
  PackageDependencies:
  - PackageIdentifier: gstreamerproject.gstreamer

[stephengillie]

The dependency is automatically checked, and installed if missing. The process of manually checking that field and installing was automated around I believe, the 1.5 release.

The dependency seems to depend on VCRedist:

So I added it as another dependency on this manifest, and it works now:

• Issue created: [Package Issue]: gstreamerproject.gstreamer #199443

But there was no change in overall outcome. It seems like the dependency isn't being found by the main application in my testing VMs. This might be unique to the VMs, so if
this isn't happening on other systems, then I'd be happy to merge it.

Verify while here:

[mtkennerly]

It looks like the GStreamer installer doesn't automatically add C:\gstreamer\1.0\msvc_x86_64\bin to the PATH environment variable. If you add that, then it should find the DLLs.

[stephengillie]

Thanks for helping me to fix that issue. Now, it needs VCRedist:

[wingetbot]

/AzurePipelines run

[stephengillie]

Verify:

(With the workaround described above of manually adding gstreamer to the path.)

[stephengillie]

@mtkennerly,

Thanks for your patience with this PR, and for helping me to validate it correctly.

[wingetbot]

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.