Pyproject #19
Merged
Pyproject #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sveinbjornt
commented
Aug 21, 2024
•
sveinbjornt
commented
- Migrated project metadata over to pyproject.toml (PEP 621)
- Migrated away from deprecated pkg_resources package
- Fixed PyPy builds (broken by changes in latest distutil :/)
- Bumped minimum Python version to 3.9 (3.8 will soon reach EOL)
…tly provide importlib with package name
vthorsteinsson
requested changes
Aug 22, 2024
pyproject.toml
Outdated
| line-length = 120 | ||
|
|
||
| [tool.black] | ||
| line-length = 120 |
There was a problem hiding this comment.
I thought we were using 88 (the standard Black setting)?
| @@ -566,9 +556,11 @@ def lines(self) -> Iterator[str]: | |||
| self._line = 0 | |||
| try: | |||
| if self._package_name: | |||
| stream = resource_stream(self._package_name, self._fname) | |||
| ref = importlib_resources.files("islenska").joinpath(self._fname) | |||
There was a problem hiding this comment.
Should the if above be changed to if self._fname?
There was a problem hiding this comment.
...or "islenska" -> self._package_name?
src/islenska/bin_build.py
Outdated
| @@ -72,6 +73,10 @@ | |||
| if MACOS: | |||
| extra_link_args = ["-stdlib=libc++", "-mmacosx-version-min=10.9"] | |||
|
|
|||
| # On some systems, the linker needs to be told to use the C++ compiler | |||
| # due to changes in the default behaviour of distutils | |||
There was a problem hiding this comment.
Include a reference URL here for further reading? Where is this coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.