Add github action for the unittest to the velero-plugin-for-vsm #31
Conversation
Use github action for the velero-plugin-for-vsm plugin. This project is within migtools where Github actions are allowed and as such it's easy to run go test is used. We do not want to run make test as this project does not have all the Makefile deps and folders for building it. Signed-off-by: Michal Pryc <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
| @@ -0,0 +1,34 @@ | |||
| name: Velero-plugin-for-vsm - '$ make test' target | |||
There was a problem hiding this comment.
I would change the name, something like CI
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
since is only one Go version, I would remove matrix syntax
| with: | ||
| go-version: ${{ matrix.go-version }} | ||
|
|
||
| - name: Go Version check |
There was a problem hiding this comment.
I think this is not necessary
| - name: Install Go dependencies | ||
| run: go get . | ||
|
|
||
| - name: Build |
There was a problem hiding this comment.
I would set build as the last step
|
If you have permission, I would open the PR from the repo and not your fork, I think that would trigger GitHub Actions prior to merge, so we can test it |
Use github action for the unit tests for velero-plugin-for-vsm plugin.
This project is within migtools where Github actions are allowed and as such it's easy to run go test is used.
We do not want to run make test as this project does not have all the Makefile deps and folders for building it.
We need to use go 1.20+, because this project has such version specified in the
go.modfile.