Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https protocol on hybrid apps instead of file protocol #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aldatsa
Copy link

@aldatsa aldatsa commented Aug 28, 2014

Hi Mike,

I found that PrettyEmbed.js doesn't work on hybrid apps created using Cordova.

Hybrid apps created with Cordova use the file protocol and that causes problems with protocol relative URLs used by PrettyEmbed.js. You get URLs like these:

file://img.youtube.com/vi/...
file://www.youtube.com/embed/...

I solved the problem checking what protocol is used and adding "https:" to the URLs when the file protocol is used.

Best regards

@Anubisss
Copy link

I had the same issue when I tried to use the lib on a local page.

I'm wondering why https is not the default.
Why want to use the http protocol instead of the secure one? I think the https should be the default and constant protocol for this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants