Rework CMake modules #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in the current state some operating systems (namely NixOS) are unable to pick up
libhackrforliquidsince they have their.hfile in a subfolder and it is only specified as part of theHINTSinstead being a part ofNAMESor asPATH_SUFFIX.I've read the CMake Documentation about
find_pathbut didn't come to a conclusion what the "correct" way would be here, so i decided to go withPATH_SUFFIX.This PR also brings a bit more consistency across the CMake modules
I've tried it with Debian, Arch and NixOS as well as macOS. I hope i didn't break stuff for anyone else.