Proof Read several Milvus Lite integrations and convert to notebook #1328
Conversation
delete open ai key delete open ai key add image
Signed-off-by: Christy Bergman <[email protected]> update quickstart
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jacksonxhx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
| @@ -913,8 +913,8 @@ | |||
| "# Define a sample question about your data.\n", | |||
| "QUESTION1 = \"What do the parameters for HNSW mean?\"\n", | |||
| "QUESTION2 = \"What are good default values for HNSW parameters with 25K vectors dim 1024?\"\n", | |||
| "QUESTION3 = \"What is the default AUTOINDEX distance metric in Milvus Client?\"\n", | |||
| "QUESTION4 = \"What does nlist mean in ivf_flat?\"\n", | |||
| "QUESTION3 = \"What does nlist vs nprobe mean in ivf_flat?\"\n", | |||
There was a problem hiding this comment.
Why changing these two lines?
There was a problem hiding this comment.
This is the commit by a previous person
| @@ -0,0 +1,873 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,873 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,873 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,873 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,873 @@ | |||
| { | |||
There was a problem hiding this comment.
Clear the output for this section.
BTW the output shows the code doesn't work. Can you double check?
Reply via ReviewNB
| @@ -0,0 +1,1205 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1205 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,191 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,601 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,601 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #15. # data: ["[{'id': 2, 'distance': 0.5859944820404053, 'entity': {'text': 'Born in Maida Vale, London, Turing was raised in southern England.', 'subject': 'history'}}, {'id': 1, 'distance': 0.5118255019187927, 'entity': {'text': 'Alan Turing was the first person to conduct substantial research in AI.', 'subject': 'history'}}]"] , extra_info: {'cost': 0}
No need to add this kind of comment in notebook. Just show the result in output cell. Please fix everywhere.
Reply via ReviewNB
| @@ -28,7 +28,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This is a commit by a previous person
|
A new version has been updated |
A reference to a related issue in your repository.
Each PR is related to an issue, and you need to list that issue.
A description of the changes proposed in the pull request.
A brief introduction to this PR.
Add delight to the experience when all tasks are complete 🎉