Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add RBAC on GetReplicaRequest #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Jan 3, 2025

issue: milvus-io/milvus#38983
this PR add RBAC on GetReplicaRequest, which define as a collection level privilege. and reuse the PrivilegeLoad, then user who has permission to load collection, could call GetReplicaRequest on the collection.

this PR add RBAC on GetReplicaRequest, which define as a
collection level privilege. and reuse the `PrivilegeLoad`,
then user who has permission to load collection, could call
GetReplicaRequest on the collection.

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot requested review from nameczz and yhmo January 3, 2025 07:23
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Jan 3, 2025

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants