Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment variables as "env" #171

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

rco-ableton
Copy link
Contributor

A small patch to allow migration scripts to access environment variables via the "env" variable, which allows some more dynamic behaviour when migrating. With this in place, it should also be trivial to add other variables and functions that make things more Terraform-like.

As part of this I added a call to t.Setenv in the test setup—I don't think this should cause any issues, but if there's a better way of going about it let me know.

Resolves #91.

Allows migration scripts to access the "env" variable, which can be used
to change behaviour dynamically.
@rco-ableton rco-ableton marked this pull request as ready for review April 5, 2024 11:42
@rco-ableton
Copy link
Contributor Author

(Missed updating the table of contents, sorry—fixed in 9d6a828)

Copy link
Owner

@minamijoyo minamijoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a cool addition! LGTM 👍

@minamijoyo minamijoyo merged commit 70e9f7d into minamijoyo:master Apr 10, 2024
8 checks passed
@minamijoyo
Copy link
Owner

Shipped it in v0.3.21 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic workspace
2 participants