Corrected the key name used for SkipPlan in state migration from "to_skip_plan" to "skip_plan". #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skip_plan" to "skip_plan".
|
@SuperHiroki Good catch! This feature was introduced in the multi_state migration and then implemented in the single-state migration, so it appears to be a bug from then. I agree that the bug should be fixed. Still, I'm concerned that the fix will introduce an incompatible change to the syntax of the HCL file, so I will try to see if we can maintain backward compatibility before cutting the next release. Thanks! |
minamijoyo
approved these changes
Dec 3, 2024
minamijoyo
added a commit
that referenced
this pull request
Dec 3, 2024
This is a follow-up to #193. Renaming the `to_skip_plan` attribute in a single-state migration block to `skip_plan` was an incompatible change to the HCL file's syntax. Since it is technically possible to maintain backward compatibility, we will continue to accept the old `to_skip_plan` and log a warning. This attribute will be removed in a future version. Use `skip_plan` instead.
minamijoyo
added a commit
that referenced
this pull request
Dec 3, 2024
This is a follow-up to #193. Renaming the `to_skip_plan` attribute in a single-state migration block to `skip_plan` was an incompatible change to the HCL file's syntax. Since it is technically possible to maintain backward compatibility, we will continue to accept the old `to_skip_plan` and log a warning. This attribute will be removed in a future version. Use `skip_plan` instead.
|
Fixed in v0.4.1 🚀 |
|
@minamijoyo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In README.md, key name used for SkipPlan in state migration is "skip_plan".
But in tfmigrate/state_migrator.go, key name used for SkipPlan in state migration is "to_skip_plan".
I followed README.md and got an error "Unsupported argument; An argument named ‘skip_plan’ is not expected here".
When I changed the key name to "to_skip_plan" from "skip_plan", no error occurred.