Allow overriding the loop flag on player_api.set_animation
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Added a commit to implement loop analogeously to speed. In particular, it needs to be remembered, otherwise you wouldn't be able to change loop when setting the same animation.
I haven't this tested yet however, make sure it still works for you. I'll test this later.
Thanks! Tested it, works perfectly. |
MoNTE48
pushed a commit
to MoNTE48/minetest_game
that referenced
this pull request
Jun 2, 2024
…t#3097) Co-authored-by: Lars Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things added/changed:
player_api.set_animation.player_api.set_animation#3095.