Limit furnace sound volume on catch-up smelting #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Jul 25, 2024
appgurueu
reviewed
Jul 25, 2024
| if items_smelt ~= 0 then | ||
| -- Play cooling sound | ||
| minetest.sound_play("default_cool_lava", | ||
| { pos = pos, max_hear_distance = 16, gain = 0.07 * math.min(items_smelt, 7) }, true) |
There was a problem hiding this comment.
Makes sense to not let it get arbitrarily loud; how did you choose this? I assume you roughly went for ~0.5 max gain?
There was a problem hiding this comment.
At first, I went for 0.05, realizing that it works but was too quiet, so I increased that to 0.07.
appgurueu
approved these changes
Jul 25, 2024
Co-authored-by: Lars Müller <[email protected]>
MoNTE48
pushed a commit
to MoNTE48/minetest_game
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the volume of smelting sound if the furnace smelts multiple items in the same timer step.
This PR is ready for review.