Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make walls connect to nodes in a new wall_connected group #3159

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

alek13
Copy link
Contributor

@alek13 alek13 commented Oct 2, 2024

walls: add ability to specify group wall_connected for blocks to which the walls will be connected

@sfan5
Copy link
Member

sfan5 commented Oct 8, 2024

What's the use case here? I don't get it.

@alek13
Copy link
Contributor Author

alek13 commented Oct 9, 2024

@sfan5 , we need ability to have walls from other blocks, then stones one or fences and connects with each other.
And on the other hand, we need to walls will be connected to node not from stones.
And also we don't want to that nodes (to which walls connects to) will be a stone and somehow took part in the recipes with group:stone. For example, default:fence have recipe with group:stone

@alek13
Copy link
Contributor Author

alek13 commented Oct 17, 2024

@sfan5 , any chance that it will be merged ?

@alek13
Copy link
Contributor Author

alek13 commented Nov 3, 2024

@sfan5 ?

@appgurueu
Copy link
Contributor

Concept seems fine to me: You want to enable arbitrary nodes to connect to walls, without having to make them have the wall, stone or fence groups. Say, for example, maybe a door. So adding a new group for that makes sense.

But I'd like for this group (and ideally also the other groups) to be documented in game_api.txt.

@appgurueu appgurueu changed the title walls: add ability to specify group wall_connected for blocks that the walls can connect to Make walls connect to wall_connected group Nov 8, 2024
@appgurueu appgurueu changed the title Make walls connect to wall_connected group Make walls connect to nodes in a new wall_connected group Nov 8, 2024
@alek13 alek13 force-pushed the walls_connected branch 2 times, most recently from bb5d27e to 2aede56 Compare November 9, 2024 16:07
@alek13
Copy link
Contributor Author

alek13 commented Nov 9, 2024

@sfan5 / @appgurueu , add info into game_api.txt

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple unrelated trailing whitespace changes and the group list is for some reason indented by 1 space but I don't care (ideally please put the trailing whitespace changes in a separate commit and dedent the list though)

@alek13
Copy link
Contributor Author

alek13 commented Nov 15, 2024

@sfan5 / @appgurueu merge ?

@sfan5 sfan5 merged commit 92daf3e into minetest:master Nov 15, 2024
2 checks passed
MoNTE48 pushed a commit to MoNTE48/minetest_game that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants