upgrade from babel-core^6.18 to @babel/core^7.2.3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHNB128
force-pushed
the
master
branch
4 times, most recently
from
57f8408 to
d7b11c5
Compare
wzhouwzhou
reviewed
Jul 10, 2019
| @@ -52,7 +56,11 @@ export default ({ types: t }) => { | |||
| const lastNode = body[lastIndex] | |||
|
|
|||
| // skip unreturnable statements | |||
| if (unreturnableStatements.has(lastNode.type)) return | |||
| try { | |||
| if (unreturnableStatements.has(lastNode.type)) return | |||
There was a problem hiding this comment.
The obvious perceivable error here would be something along the lines of Cannot read property 'type' of null or undefined, so is a try/catch and using errors for control flow needed here?
wzhouwzhou
reviewed
Jul 10, 2019
| @@ -1,2 +1 @@ | |||
| node_modules | |||
| lib | |||
There was a problem hiding this comment.
Is there a particular reason why lib is commented out in the gitignore instead of perhaps npmignore? On the flipside, unprocessed sources can be npm ignored
|
+1 on this thread, it would be amazing if @miraks responded to this and kept this up-to-date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A try to use implicit-return over babel 7 and catch some error.
Then decide to update you lib from 6 to 7 and it made sense.