Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Update 6 #64

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from
Open

Fix for Update 6 #64

wants to merge 2 commits into from

Conversation

YaaZ
Copy link

@YaaZ YaaZ commented Oct 4, 2022

  1. Fixed compilation for Update 6
  2. Hide outlines when deselecting objects one by one
  3. Fixed many difficult to catch crashes in GC and when placing blueprints (mainly by fixing object flags serialization)
  4. Items are now taken from the inventory again
  5. Respect dismantle multipliers for blueprint build costs (fixes conveyor & pipe costs)

Known issues

  1. Selecting objects one by one still looks ugly (only some parts of the building are highlighted), I couldn't find a method which could fully highlight multiple buildings (how does vanilla multiple selection work BTW?)
  2. Weird build gun behavior, it may be still shown after all actions are closed, or be hidden when building blueprints (observed when blueprint was selected by hotkey)
  3. CalculateBoundingBox segfaults at addr=0 when creating blueprint with only one conveyor
  4. Factory legs are not copied
  5. Placing blueprint with pipes & junctions and then trying to attach pipe to junction crashes

@YaaZ
Copy link
Author

YaaZ commented Oct 4, 2022

@mircearoata 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant