Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Desktop support for local notification #44

Merged
merged 10 commits into from
Jul 7, 2024

Conversation

mirzemehdi
Copy link
Owner

If tray is supported then tray notification is shown, otherwise JOptionPane dialog is shown

fun getNotifier(configuration: NotificationPlatformConfiguration.Desktop): Notifier {
        return when {
            TrayNotifier.isSupported -> TrayNotifier(configuration = configuration)
            //TODO for now return JOptionPaneNotifier for not supported platforms
            else -> JOptionPaneNotifier(configuration = configuration)
        }
    }```

@mirzemehdi mirzemehdi self-assigned this Jul 7, 2024
@mirzemehdi mirzemehdi added the enhancement New feature or request label Jul 7, 2024
@mirzemehdi mirzemehdi linked an issue Jul 7, 2024 that may be closed by this pull request
@mirzemehdi mirzemehdi merged commit 14d4a92 into rc_1.1.0 Jul 7, 2024
mirzemehdi added a commit that referenced this pull request Jul 8, 2024
* Implementing Desktop support for local notification (#44)

* Initializing Desktop target

* Initial local notifier implementation

* Implementation of joptionspane for not supported tray notification

* Updating api, and ReadME
@mirzemehdi mirzemehdi deleted the desktop_support branch July 19, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for desktop (JVM) ?
1 participant