Check that sentinel endpoints are defined

Previously, the init() method of the 2PC sentinel controller would exhibit a non-existent element access if no sentinel endpoints were defined. With this commit, the code now checks that at least one endpoint is defined and logs an error if it's not. Signed-off-by: Michael L. Szulczewski <[email protected]>
mit-dci · Sep 27, 2022 · 46771a9 · 46771a9
1 parent 33292cc
commit 46771a9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/uhs/twophase/sentinel_2pc/controller.cpp b/src/uhs/twophase/sentinel_2pc/controller.cpp
@@ -25,6 +25,11 @@ namespace cbdc::sentinel_2pc {
                                                    .size())]) {}
 
     auto controller::init() -> bool {
+        if(m_opts.m_sentinel_endpoints.empty()) {
+            m_logger->error("No sentinel endpoints are defined.");
+            return false;
+        }
+
         if(m_sentinel_id >= m_opts.m_sentinel_endpoints.size()) {
             m_logger->error(
                 "The sentinel ID is too large for the number of sentinels.");

diff --git a/tests/unit/sentinel_2pc/controller_test.cpp b/tests/unit/sentinel_2pc/controller_test.cpp
@@ -260,3 +260,14 @@ TEST_F(sentinel_2pc_test, out_of_range_sentinel_id) {
                                                            m_logger);
     ASSERT_FALSE(ctl->init());
 }
+
+TEST_F(sentinel_2pc_test, no_sentinel_endpoints) {
+    m_opts.m_sentinel_endpoints.clear();
+    auto ctl = std::make_unique<cbdc::sentinel_2pc::controller>(0,
+                                                                m_opts,
+                                                                m_logger);
+
+    // Check that the controller fails to initialize if no sentinel endpoints
+    // are defined.
+    ASSERT_FALSE(ctl->init());
+}