Adding support for mermaid directives and themeVariables #192
Conversation
markdownPreview/index.ts
Outdated
| @@ -6,17 +6,27 @@ function init() { | |||
| const darkModeTheme = configSpan?.dataset.darkModeTheme; | |||
| const lightModeTheme = configSpan?.dataset.lightModeTheme; | |||
|
|
|||
| const directives = JSON.parse(configSpan?.dataset.directives ?? ''); | |||
There was a problem hiding this comment.
This should be wrapped in a try catch in case it fails
| Example (add to `setttings.json`): | ||
| ```json | ||
| { | ||
| "markdown-mermaid.directives": { |
There was a problem hiding this comment.
This new setting should also be documented in the package.json
markdownPreview/index.ts
Outdated
| @@ -6,17 +6,27 @@ function init() { | |||
| const darkModeTheme = configSpan?.dataset.darkModeTheme; | |||
| const lightModeTheme = configSpan?.dataset.lightModeTheme; | |||
|
|
|||
| const directives = JSON.parse(configSpan?.dataset.directives ?? ''); | |||
| const directivesDebug = 'debug' in directives ? directives.debug : false; | |||
There was a problem hiding this comment.
When would users need the debug option?
src/index.ts
Outdated
| const lightModeTheme = "themeVariables" in directives ? | ||
| 'base' : sanitizeMermaidTheme(config.get('lightModeTheme')); | ||
|
|
||
| /* |
src/index.ts
Outdated
|
|
||
| // Note: single quotes needed for directives | ||
| // JSON.stringify will contain double quotes | ||
| // encodeURIcomponent could be used to be safer |
There was a problem hiding this comment.
Can't the json itself still contain single quotes, such as inside strings?
src/index.ts
Outdated
| // Setting themeVariables will override | ||
| // darkModeTheme and lightModeTheme | ||
| // both will be set to "base" | ||
| const darkModeTheme = "themeVariables" in directives ? |
There was a problem hiding this comment.
Can you explain why themeVariables need to reset the theme?
|
@mjbvz If I submit a pr adding a try/catch around |
|
Pushed fix for merge conflicts and using try catch. Still not convinced on merging this yet because:
|
User can modify setttings.json to set mermaid directives and themeVariables.