docs: add more TRACE calls for easier debugging #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleehammer
reviewed
Feb 5, 2024
| @@ -154,6 +154,8 @@ static bool ApplyPreconnAttrs(HDBC hdbc, SQLINTEGER ikey, PyObject *value, char | |||
| return false; | |||
| } | |||
|
|
|||
| TRACE("ApplyPreconnAttrs.SQLSetConnectAttrW key=%d value=%p vallen=%d\n", ikey, ivalue); | |||
There was a problem hiding this comment.
I haven't tested this locally, but it appears there are 3 placeholders and 2 values.
mkleehammer
reviewed
Feb 5, 2024
| @@ -1310,6 +1310,8 @@ void FreeParameterData(Cursor* cur) | |||
| { | |||
| // Unbinds the parameters and frees the parameter buffer. | |||
|
|
|||
| TRACE("FreeParameterData"); | |||
mkleehammer
reviewed
Feb 5, 2024
| @@ -750,12 +758,16 @@ static PyObject* execute(Cursor* cur, PyObject* pSql, PyObject* params, bool ski | |||
| const char* pch = PyBytes_AS_STRING(query.Get()); | |||
| SQLINTEGER cch = (SQLINTEGER)(PyBytes_GET_SIZE(query.Get()) / (isWide ? sizeof(uint16_t) : 1)); | |||
|
|
|||
| TRACE("cursor.execute: isWide=%d query_len=%d\n", isWide, cch); | |||
There was a problem hiding this comment.
Since we build on so many platforms with different pointer & integer widths, I think we should cast anything that is not a plain integer when using %d. Most likely everything is 64 bits nowdays, but it would't hurt.
|
Looks good, but I added 3 comments in the Files changed tab using the web UI. Can you take a look at those? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this useful when debugging a handling
SQLFreeStmtcommand on my driver (netsuite).