second argument for getException should be passed in seconds (not milliseconds) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to getException on line 63 currently receives a second argument in milliseconds.
However getException expects a value in seconds because the key parameter is ultimately tested against event_length which is denominated in seconds. If you pass in milliseconds, getException wil always return false and no overlaps of recurrent events and their exceptions will be filtered out.
Fixed by dividing the second argument of the getException call by 1000