Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second argument for getException should be passed in seconds (not milliseconds) #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

saltomodules
Copy link

@saltomodules saltomodules commented Dec 30, 2016

The call to getException on line 63 currently receives a second argument in milliseconds.

However getException expects a value in seconds because the key parameter is ultimately tested against event_length which is denominated in seconds. If you pass in milliseconds, getException wil always return false and no overlaps of recurrent events and their exceptions will be filtered out.

Fixed by dividing the second argument of the getException call by 1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant