LoRA: add sort data flag #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
May 3, 2024
Comment on lines
+102
to
+103
| indices = np.arange(len(dataset)) | ||
| indices = np.random.permutation(indices) |
There was a problem hiding this comment.
Suggested change
| indices = np.arange(len(dataset)) | |
| indices = np.random.permutation(indices) | |
| indices = np.random.permutation(len(dataset)) |
awni
reviewed
May 3, 2024
Comment on lines
+104
to
+108
| # Make batches | ||
| batch_idx = [ | ||
| indices[i : i + batch_size] | ||
| for i in range(0, len(indices) - batch_size + 1, batch_size) | ||
| ] |
There was a problem hiding this comment.
Can you pull this out of the if statement and remove the duplicate one above?
awni
reviewed
May 3, 2024
| @@ -75,6 +75,11 @@ def build_parser(): | |||
| type=str, | |||
| help="Directory with {train, valid, test}.jsonl files", | |||
| ) | |||
| parser.add_argument( | |||
| "--sort-by-data-length", | |||
There was a problem hiding this comment.
Do you mind changing this to --sort-data-by-length?
awni
reviewed
May 3, 2024
|
I will address comments like this and the need to resolve code conflicts later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #583