Optimize MapX.Assign and MapX.NewWith (#449)

mlange-42 · Dec 26, 2024 · 837c3c3 · 837c3c3
1 parent 128b0c1
commit 837c3c3
Show file tree

Hide file tree

Showing 3 changed files with 208 additions and 200 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,13 @@
 
 ## [[unpublished]](https://github.com/mlange-42/arche/compare/v0.14.1...main)
 
+### Performance
+
+* Optimize `MapX.Assign` and `MapX.NewWith` by use of `World.GetUnchecked` (#449)
+
 ### Documentation
 
-* Fix method names and ordering in benchmark tables (448)
+* Fix method names and ordering in benchmark tables (#448)
 
 ## [[v0.14.1]](https://github.com/mlange-42/arche/compare/v0.14.0...v0.14.1)
 

diff --git a/generic/_generate/main.go b/generic/_generate/main.go
@@ -95,7 +95,11 @@ func generateMaps() {
 				returnAllSafe += ",\n"
 				arguments += ", "
 			}
-			assign += fmt.Sprintf("*(*%s)(m.world.Get(entity, m.id%d)) = *%s\n", typeLetters[j], j, strings.ToLower(typeLetters[j]))
+			if j == 0 {
+				assign += fmt.Sprintf("*(*%s)(m.world.Get(entity, m.id%d)) = *%s\n", typeLetters[j], j, strings.ToLower(typeLetters[j]))
+			} else {
+				assign += fmt.Sprintf("*(*%s)(m.world.GetUnchecked(entity, m.id%d)) = *%s\n", typeLetters[j], j, strings.ToLower(typeLetters[j]))
+			}
 		}
 
 		data := query{