Merge pull request #96 from mlibrary/query-error

fix: callnumber browse items without a catlog record
mlibrary · Jul 24, 2023 · 81f9917 · 81f9917
2 parents ebc7c69 + 48b49d1
commit 81f9917
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/models/callnumber_item.rb b/lib/models/callnumber_item.rb
@@ -1,7 +1,7 @@
 class CallnumberItem
   def initialize(browse_doc:, catalog_doc:, exact_match:)
     @browse_doc = browse_doc
-    @catalog_doc = catalog_doc
+    @catalog_doc = catalog_doc || {}
     @exact_match = exact_match
   end
 

diff --git a/spec/models/callnumber_item_spec.rb b/spec/models/callnumber_item_spec.rb
@@ -25,6 +25,10 @@
       @catalog_doc["edition"] = ["my edition", "vernacular edition"]
       expect(subject.title).to eq("Zhiznʹ gospodina de Molʹera / M. Bulgakov ; [podgot. teksta i poslesl. V.I. Loseva]. my edition")
     end
+    it "is an empty string when there is no matching catalog record" do
+      @catalog_doc = nil
+      expect(subject.title).to eq("")
+    end
   end
   context "#vernacular_title" do
     it "shows vernacular title without edition when there isn't one" do