Resource path resolver #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
respinos
reviewed
Dec 17, 2024
| type=self.get_type(), | ||
| events=self.get_preservation_events(), | ||
| metadata_files=self.get_metadata_files(), | ||
| data_files=self.get_data_files(), | ||
| struct_maps=self.get_struct_maps(), | ||
| ) | ||
|
|
||
| def _apply_relative_path(self, descriptor_path: Path, path_to_apply: str) -> str: | ||
| if path_to_apply.startswith("../"): |
There was a problem hiding this comment.
I need to think some more about this; we don't want a path relative to the running directory (cwd) --- that's too much path. Working in the console doing the following gives the result I was expecting.
combined_path = (descriptor_path / path_to_apply)
new_relative_path = combined_path.relative_to(descriptor_path / "..")
There was a problem hiding this comment.
Yes, you are correct.I tried a different approach, but when I run the tests from the CWD, it causes the paths to be resolved from there. This creates issue because I need the paths to be relative to a specific directory, not the CWD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the _apply_relative_path method to the Parser class instead of PackageResourceProvider to avoid a circular dependency. Additionally, since the resolution of the path for locref is now happening within the parser, I added the _apply_relative_path method there.
Please let me know if you think this approach is sound or if you have any alternative suggestions.