API client constructor needs URL

apache/client/include/lauth/api_client.hpp

@@ -9,7 +9,7 @@
 namespace mlibrary::lauth {
   class ApiClient {
     public:
-      ApiClient() : client(std::make_unique<HttpClient>("http://localhost:9000")) {};
+      ApiClient(const std::string& url) : client(std::make_unique<HttpClient>(url)) {};
       ApiClient(std::unique_ptr<HttpClient>&& client) : client(std::move(client)) {};
       ApiClient(const ApiClient&) = delete;
       ApiClient& operator=(const ApiClient&) = delete;

apache/client/include/lauth/authorizer.hpp

@@ -10,7 +10,7 @@
 namespace mlibrary::lauth {
   class Authorizer {
     public:
-      Authorizer() : client(std::make_unique<ApiClient>()) {};
+      Authorizer(const std::string& url) : client(std::make_unique<ApiClient>(url)) {};
       Authorizer(std::unique_ptr<ApiClient>&& client) : client(std::move(client)) {};
       Authorizer(const Authorizer&) = delete;
       Authorizer& operator=(const Authorizer&) = delete;

apache/client/src/lauth/http_client.cpp

@@ -8,7 +8,7 @@ namespace mlibrary::lauth {
 
     auto res = client.Get(path);
 
-    return res->body;
+    return res ? res->body : "";
   }
 }
 

apache/client/test/lauth/api_client_test.cpp

@@ -39,7 +39,7 @@ TEST(ApiClient, denied_by_mock_http_client) {
 }
 
 TEST(ApiClient, a_request_with_no_user_is_denied) {
-  ApiClient client;
+  ApiClient client("http://localhost:9000");
   Request request;
 
   bool result = client.isAllowed(request);
@@ -48,7 +48,7 @@ TEST(ApiClient, a_request_with_no_user_is_denied) {
 
 
 TEST(ApiClient, a_request_with_authorized_user_is_allowed) {
-  ApiClient client;
+  ApiClient client("http://localhost:9000");
   Request request;
 
   request.user = "authorized";
@@ -57,7 +57,7 @@ TEST(ApiClient, a_request_with_authorized_user_is_allowed) {
 }
 
 TEST(ApiClient, a_request_with_unauthorized_user_is_denied) {
-  ApiClient client;
+  ApiClient client("http://localhost:9000");
   Request request;
 
   request.user = "unauthorized";

apache/client/test/lauth/mocks.hpp

@@ -8,6 +8,7 @@ using namespace mlibrary::lauth;
 
 class MockApiClient : public ApiClient {
     public:
+    MockApiClient() : ApiClient("http://localhost:9000") {};
     MOCK_METHOD(bool, isAllowed, (Request), (override));
 };
 

apache/module/mod_lauth.cpp

@@ -38,17 +38,13 @@ static authz_status lauth_check_authorization(request_rec *r,
        return AUTHZ_DENIED_NO_USER;
     }
 
-    if (Authorizer().isPasswordOnly(r->uri) && !r->user) {
-      return AUTHZ_DENIED_NO_USER;
-    }
-
     Request req {
       .ip = r->useragent_ip ? std::string(r->useragent_ip) : "",
       .uri = r->uri ? std::string(r->uri) : "",
       .user = r->user ? std::string(r->user) : ""
     };
 
-    return Authorizer().isAllowed(req) ? AUTHZ_GRANTED : AUTHZ_DENIED;
+    return Authorizer("http://api-mock:9000").isAllowed(req) ? AUTHZ_GRANTED : AUTHZ_DENIED;
 }
 
 static const authz_provider authz_lauth_provider =