Merge pull request #77 from mlibrary/do-not-fetch

Remove pre-fetching for grant associations

lauth/app/repositories/grant_repo.rb

@@ -14,8 +14,7 @@ def for_collection_class(username:, client_ip:, collection_class:)
           .join(collections.name.dataset, uniqueIdentifier: grants[:coll], dlpsDeleted: "f")
           .where(collections[:dlpsClass] => collection_class)
 
-        rel = grants.class.new(ds)
-        rel.to_a
+        grants.class.new(ds).to_a
       end
 
       def for(username:, collection:, client_ip: nil)
@@ -25,8 +24,7 @@ def for(username:, collection:, client_ip: nil)
         ds = base_grants_for(username: username, network: smallest_network)
           .where(grants[:coll] => collection.uniqueIdentifier)
 
-        rel = grants.class.new(ds)
-        rel.combine(:user, institutions: {institution_memberships: :users}).to_a
+        grants.class.new(ds).to_a
       end
 
       private

lauth/spec/repositories/grant_repo_spec.rb

@@ -59,15 +59,6 @@
 
           expect(grants).to eq []
         end
-
-        # TODO: extract this
-        describe "grant association loading" do
-          subject(:found_grant) { repo.for(username: "lauth-allowed", collection: collection).first }
-
-          it "loads user" do
-            expect(found_grant.user.userid).to eq grant.user.userid
-          end
-        end
       end
 
       context "with a member of an authorized institution" do