Add AuthorizationResult type

mlibrary · Nov 14, 2023 · bf07fb8 · bf07fb8
1 parent 63408dc
commit bf07fb8
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 2 deletions.
diff --git a/apache/client/include/lauth/api_client.hpp b/apache/client/include/lauth/api_client.hpp
@@ -5,6 +5,7 @@
 
 #include "lauth/http_client.hpp"
 #include "lauth/request.hpp"
+#include "lauth/authorization_result.hpp"
 
 namespace mlibrary::lauth {
   class ApiClient {
@@ -18,6 +19,7 @@ namespace mlibrary::lauth {
       virtual ~ApiClient() = default;
 
       virtual bool authorized(Request req);
+      virtual AuthorizationResult authorize(Request req);
 
     protected:
       std::unique_ptr<HttpClient> client;

diff --git a/apache/client/include/lauth/authorization_result.hpp b/apache/client/include/lauth/authorization_result.hpp
@@ -0,0 +1,12 @@
+#ifndef __LAUTH_AUTHORIZATION_RESULT_HPP__
+#define __LAUTH_AUTHORIZATION_RESULT_HPP__
+
+#include <string>
+
+namespace mlibrary::lauth {
+  struct AuthorizationResult {
+    std::string determination;
+  };
+}
+
+#endif // __LAUTH_AUTHORIZATION_RESULT_HPP__
diff --git a/apache/client/meson.build b/apache/client/meson.build
@@ -42,6 +42,7 @@ liblauth = shared_library(
 
 install_headers(
   'include/lauth/api_client.hpp',
+  'include/lauth/authorization_result.hpp',
   'include/lauth/authorizer.hpp',
   'include/lauth/http_client.hpp',
   'include/lauth/http_params.hpp',

diff --git a/apache/client/src/lauth/api_client.cpp b/apache/client/src/lauth/api_client.cpp
@@ -18,4 +18,16 @@ namespace mlibrary::lauth {
 
     return rvalue["result"] == "allowed";
   }
+
+  AuthorizationResult ApiClient::authorize(Request req) {
+    HttpParams params {
+      {"uri", req.uri},
+      {"user", req.user}
+    };
+
+    auto result = client->get("/authorized", params);
+    json rvalue = json::parse(*result);
+
+    return AuthorizationResult{.determination = "denied"};
+  }
 }
diff --git a/apache/client/test/lauth/api_client_test.cpp b/apache/client/test/lauth/api_client_test.cpp
@@ -9,6 +9,7 @@ using ::testing::Return;
 
 #include "lauth/api_client.hpp"
 #include "lauth/request.hpp"
+#include "lauth/authorization_result.hpp"
 
 using namespace mlibrary::lauth;
 
@@ -54,6 +55,6 @@ TEST(ApiClient, ResponseOfDeniedReturnsFalse) {
   EXPECT_CALL(*client, get(_, _)).WillOnce(Return(body));
   ApiClient api_client(std::move(client));
 
-  auto allowed = api_client.authorized(Request());
-  EXPECT_THAT(allowed, false);
+  auto authorized = api_client.authorize(Request());
+  EXPECT_THAT(authorized.determination, "denied");
 }