Fix mock server tests #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log all GETs in mock API - Fix mock-api hostname - Check environment for LAUTH_TEST_API_URL - Specify localhost:9000 as default mock API, mock-api:9000 when running library tests with Compose - Add HttpClient::getOptional
The mock server is not intended to serve requests/responses for all tests. We only intend to use it to ensure that we handle URLs, query parameters, headers, and general HTTP matters correctly. Everything "outward" from here should use mocks, generally, out to the system tests, which will use a real API. The HttpClient response bodies can be mocked inline in the ApiClient tests for locality and ease. The mock really server only needs to run for http_client_test.cpp.
This ensures that the mock API is up so the HttpClient tests can run without setting anything up or setting environment manually.
Run on pushes to main and changes to pull requests, not every commit, which was triggering two runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.