Projection scenarios #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a bug where the collection repo would match the first matching location, this was finding the grant for lauth-allowed on the username test fixture and still passing. The test was always intended to use the inst user. This change addresses that.
These would be identical to the other tests, and not provide additional coverage or value.
malakai97
force-pushed
the
projection
branch
from
f099f27 to
82b83c1
Compare
DRY GrantRepo and add missing soft delete support on for_collection_class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built over #69, so we should merge that first.Adds the projection scenario tests and corresponding fixture, config, api tests, and implementation.
We removed the proxy-focused scenarios. These were going to end up being the same as what we were already writing, and offered no further coverage.
The apache config is getting a little verbose. Most of the locations are identical, so there's probably a way to clean it up. Not something I've gotten to.