Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-905] When text service is restored, undo UI changes in select & act #407

Conversation

erinesullivan
Copy link
Contributor

@erinesullivan erinesullivan commented Sep 15, 2023

Overview

This pull request reenables the Text action.

DO NOT MERGE UNTIL TWILIO TEXTING SERVICE HAS BEEN RESTORED

This pull request resolves LIBSEARCH-905.

Anything else?

Class to Funcational Components

In an ongoing effort to convert the class components into functional components to follow today's React practices, these components have all been rewritten as they are in relation to the Text action:

  • PermalinkAction
  • FileAction
  • CitationAction
  • TextAction
  • EmailAction
  • ActionsList
  • List

Underscore

Underscore "...is a JavaScript library that provides a whole mess of useful functional programming helpers without extending any built-in objects." Search only uses a handful of this massive library, so in order to reduce the need for the dependency, src/modules/reusable/underscore/index.js was created to recreate those functions and use them throughout the project. Once all of the functions have been replaced, underscore can be uninstalled.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Go to a record and look at the list of Actions.
    • Is the Text action no longer grayed out?
    • Can you click on it?
    • Do you no longer see a message that says Texting records to your mobile device is temporarily unavailable.?
    • Are you able to successfully perform all the other actions?

@erinesullivan erinesullivan self-assigned this Sep 15, 2023
@erinesullivan erinesullivan marked this pull request as ready for review September 20, 2023 12:56
@bertrama bertrama merged commit 80e5e15 into master Oct 24, 2023
5 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-905-when-text-service-is-restored-undo-ui-changes-in-select-act branch February 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants