Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-801] Implement "clear active filters" designs for advanced search (Part 2) #497

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

This pull request focuses on increasing performance of the overall Advanced Search pages. Below are the noted changes:

  • removeFieldedSearch, and setFieldedSearch have been moved to FieldInput as those functions are only ever handled in that component.
  • removeUndefinedFilters logic has been updated and applied directly to activeFilters.
  • FieldInput and SearchByOptions only ever use the uid of the current datastore. Instead of passing in the entire object, only the string gets passed in.
  • Object destructuring to reduce repeated code.
  • Wrapped FieldInput in memo to prevent unnecessary re-renders when the props haven't changed.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Go to Advanced Search. Doe everything work as expected?

@erinesullivan erinesullivan self-assigned this Oct 18, 2024
@erinesullivan erinesullivan merged commit 7f3102c into master Oct 18, 2024
7 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-801-part-2 branch October 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant