[LIBSEARCH-801] Implement "clear active filters" designs for advanced search (Part 2) #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request focuses on increasing performance of the overall Advanced Search pages. Below are the noted changes:
removeFieldedSearch
, andsetFieldedSearch
have been moved toFieldInput
as those functions are only ever handled in that component.removeUndefinedFilters
logic has been updated and applied directly toactiveFilters
.FieldInput
andSearchByOptions
only ever use theuid
of the current datastore. Instead of passing in the entire object, only the string gets passed in.FieldInput
inmemo
to prevent unnecessary re-renders when the props haven't changed.Testing