Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-801] Implement "clear active filters" designs for advanced search (Part 3) #498

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

erinesullivan
Copy link
Contributor

Overview

This pull request focuses on making changes to the Multiselect component. Below are the noted changes:

  • Replaced Checkbox component with native HTML checkbox inputs, and styled them to be similar to the replaced component.
  • Separated Mutliselect from AdvancedFilter for easier access and control.
  • Created AdvancedSearchSubmit component to reduce repeated code.
  • Updated Multiselect to set advanced filters on load based on the current filters set by the URL.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check advanced search and compare it to the current site.
    • Does it look and feel the same?
    • If there are filters set, do they carry throughout the datastore?
    • If you are given a direct link with filters applied to the URL, do those filters become active on load?

@erinesullivan erinesullivan self-assigned this Oct 22, 2024
@erinesullivan erinesullivan merged commit e2b4cbf into master Oct 22, 2024
7 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-801-part-3 branch October 22, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant