Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBSEARCH-801] Implement "clear active filters" designs for advanced search (Part 4) #499

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

erinesullivan
Copy link
Contributor

@erinesullivan erinesullivan commented Oct 23, 2024

Overview

This pull request focuses on making changes to the DateRangeInput component. Below are the noted changes:

  • Separated DateRangeInput from AdvancedFilter for easier access and control.
  • Updated DateRangeInput to use number input types instead of text.
  • Added styles for input[type="number"].
  • Updated Multiselect with simpler logic, and to set advanced filters on load based on the current filters set by the URL.
  • Moved logic for grabbing current and advanced filters into FiltersContainer to resolve the Selector unknown... warning.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check advanced search and compare it to the current site.
    • Does it look and feel the same?
    • If there are filters set, do they carry throughout the datastore?
    • If you are given a direct link with filters applied to the URL, do those filters become active on load?

… called with the same parameters. This can lead to unnecessary rerenders.`
…rectly to `FiltersContainer`. Rebuilding `DateRangeInput`.
…d code, and to resolve the warning: `Selector unknown returned a different result when called with the same parameters. This can lead to unnecessary rerenders.`
@erinesullivan erinesullivan merged commit bc34606 into master Oct 29, 2024
6 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-801-part-4 branch October 29, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant