Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ranger did not receive num.threads = 1 during predict() #294

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jemus42
Copy link
Member

@jemus42 jemus42 commented Oct 10, 2023

Here

pv = self$param_set$get_values(tags = "predict")
newdata = ordered_features(task, self)
prediction = predict(object = self$model, data = newdata)

the parameters were retrieved, but never actually passed to predict().

This caused an issue in a benchmark setting where the prediction step caused a large spike in CPU load, and after asking Marvin he confirmed that prediction was multi-threaded in ranger, so this PR should fix that.

@jemus42 jemus42 changed the title fix: ranger did not receive num.threads = 1 during () fix: ranger did not receive num.threads = 1 during predict() Oct 10, 2023
@sebffischer sebffischer merged commit be40f64 into mlr-org:main Oct 11, 2023
1 of 3 checks passed
@jemus42 jemus42 deleted the fix-ranger-predict-pv branch October 11, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants