fix: ranger did not receive num.threads = 1
during predict()
#294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
mlr3extralearners/R/learner_ranger_surv_ranger.R
Lines 118 to 120 in 0b3c766
the parameters were retrieved, but never actually passed to
predict()
.This caused an issue in a benchmark setting where the prediction step caused a large spike in CPU load, and after asking Marvin he confirmed that prediction was multi-threaded in ranger, so this PR should fix that.