perf: pass numeric by reference in assert_surv

mlr-org · Aug 23, 2024 · 7f6354e · 7f6354e
1 parent 737498e
commit 7f6354e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/src/RcppExports.cpp b/src/RcppExports.cpp
@@ -11,12 +11,12 @@ Rcpp::Rostream<false>& Rcpp::Rcerr = Rcpp::Rcpp_cerr_get();
 #endif
 
 // c_assert_surv
-bool c_assert_surv(NumericMatrix mat);
+bool c_assert_surv(const NumericMatrix& mat);
 RcppExport SEXP _mlr3proba_c_assert_surv(SEXP matSEXP) {
 BEGIN_RCPP
     Rcpp::RObject rcpp_result_gen;
     Rcpp::RNGScope rcpp_rngScope_gen;
-    Rcpp::traits::input_parameter< NumericMatrix >::type mat(matSEXP);
+    Rcpp::traits::input_parameter< const NumericMatrix& >::type mat(matSEXP);
     rcpp_result_gen = Rcpp::wrap(c_assert_surv(mat));
     return rcpp_result_gen;
 END_RCPP

diff --git a/src/survival_assert.cpp b/src/survival_assert.cpp
@@ -2,26 +2,25 @@
 using namespace Rcpp;
 
 // [[Rcpp::export]]
-bool c_assert_surv(NumericMatrix mat) {
-  for (int i = 0; i < mat.nrow(); i++) {
-    // check first element
-    if (mat(i, 0) < 0 || mat(i, 0) > 1) {
-      return false;
-    }
+bool c_assert_surv(const NumericMatrix& mat) {
+    for (int i = 0; i < mat.nrow(); i++) {
+        if (mat(i, 0) < 0 || mat(i, 0) > 1) {
+            // check first element
+            return false;
+        }
 
-    for (int j = 1; j < mat.ncol(); j++) {
-      // S(t) in [0,1]
-      if (mat(i, j) < 0 || mat(i, j) > 1) {
-        return false;
-      }
+        for (int j = 1; j < mat.ncol(); j++) {
+            // S(t) in [0,1]
+            if (mat(i, j) < 0 || mat(i, j) > 1) {
+                return false;
+            }
 
-      // S(t) should not increase!
-      if (mat(i, j) > mat(i, j - 1)) {
-        return false;
-      }
+            // S(t) should not increase!
+            if (mat(i, j) > mat(i, j - 1)) {
+                return false;
+            }
+        }
     }
-  }
 
   return true;
 }
-