Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Surv to classif pipeline #194 #391

Merged
merged 72 commits into from
Jul 25, 2024
Merged

Draft Surv to classif pipeline #194 #391

merged 72 commits into from
Jul 25, 2024

Conversation

studener
Copy link
Collaborator

No description provided.

@studener studener requested a review from bblodfon June 12, 2024 12:08
@bblodfon
Copy link
Collaborator

bblodfon commented Jun 14, 2024

  • run document() to generate the docs and get the exported objects
  • add tests
  • make pipeline_survtoclassif (see pipeline_survtoregr) that uses the two PipeOps consesutively
  • pammtools::as_ped => to base R => we import pammtools for now, no need to do anything further here
  • add cut hyperparameter

R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
test_reduction_pipeline.R Outdated Show resolved Hide resolved
test_reduction_pipeline.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpPredClassifSurv.R Outdated Show resolved Hide resolved
R/PipeOpPredClassifSurv.R Outdated Show resolved Hide resolved
R/PipeOpPredClassifSurv.R Outdated Show resolved Hide resolved
R/PipeOpPredClassifSurv.R Outdated Show resolved Hide resolved
@adibender
Copy link
Collaborator

In the end run some sanity check:

  • use task generator to generate survival data
  • use discSurv package + logistic regression -> compare to our pipeline (e.g. same coefficients, etc.)
  • use misscpecified model (without covariate that has effect) and correctly specified model (with covariate with effect) to check that c-index, brier-score etc. have better values for correctly specified model

R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
R/PipeOpTaskSurvClassif.R Outdated Show resolved Hide resolved
@bblodfon bblodfon merged commit 6548c5b into main Jul 25, 2024
4 checks passed
@bblodfon bblodfon deleted the surv_to_classif_pipeline branch July 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants