perf: optimize Rcpp

[m-muecke]

No description provided.

[bblodfon]

I see some const and &, that's I guess to avoid creating a copy right? Also dev-check fails, is it due to that?

[m-muecke]

I see some const and &, that's I guess to avoid creating a copy right? Also dev-check fails, is it due to that?

Yeah thats for passing args by reference and hence avoiding the copy. I believe dev-check if failing due to mlr3 changes, but will check it out.

[bblodfon]

Max, for the c_weight_survival_score I think you've just changed the "spacing" of the code, right (not the logic)? I can't check line-to-line here, so please verify! (I had checked that the C code worked even though it is very complicated as we use it in a paper)

[m-muecke]

Max, for the c_weight_survival_score I think you've just changed the "spacing" of the code, right (not the logic)? I can't check line-to-line here, so please verify! (I had checked that the C code worked even though it is very complicated as we use it in a paper)

Not quite, the args also passed by reference instead of copy.