feat(LearnerTorch): tensor_dataset parameter #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #131
Open Questions:
Do we want special handling of
lazy_tensor
s (data augmentation). This would require annotating the preprocessing operators with whether they are stochastic or not. If alazy_tensor
is stochastic, we should not allow using thetensor_dataset
parameterAnswer: I think it is better to implement something like
po("materialize_lazy_tensor")
, which takes in a Task with one or more lazy tensors and converts them internally to atensor_dataset
, which will make the dataloading efficient.TODOs:
tensor_dataset