Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Finally Use Mffpy for read_raw_egi #12981

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scott-huberty
Copy link
Contributor

@scott-huberty scott-huberty commented Nov 21, 2024

closes #6937
Maybe also #11380 ?
xref #8038

This is not ready for review(!) But I am using mffpy for a project and so I figured I would get this on the board..

Maybe a good target date for merge would be just after the MNE 1.9 release, so that devs can work with it for a few months before it is shipped in a stable release.

TODO:

  • 1 Make it work
  • Make it work with EEG data
  • Make it work with EEG + PNS data
  • Make it work with data with acquisition skips
  • Re-integrate support for reading in channel status (e.g. bad channels)
  • Get CI's green (specifically the MFF testing code).
  • 2 Make it pretty
  • Clean up the code
  • Address all TODO/XXX comments
  • Add tutorial for reading in calibration data directly with mffpy
  • 3 RFC:
  • Do we remove our custom reading code or keep it for legacy purposes?

@scott-huberty scott-huberty marked this pull request as draft November 21, 2024 18:24
- more functional
- annotate acquisition skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove / Replace EGI reader by https://pypi.org/project/mffpy/
1 participant