Update network.py #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am working on your online book and projects using Python 3.5. Since I used a different and newer python version, I came across several problems and solved them by making some changes in network.py and mnist_loader files. Now the code is compatible with Python 3.5 The biggest problem is zip variables haven't len() attribute in 3.5. So I converted training_data, test_data to the list variables. I had to make a deep copy of original training and test data because when they are converted to list variables, they can't be reused.
|
I'm pretty sure the creator isn't planning on porting to python 3 so he's unlikely to merge this. Have you managed to port the code though? |
|
Yes I ported the code and I made the commit with the explanations above :) |
|
The data could stay in zip form if the data was temporarily converted to list type and then applied the |
|
How can I get the complete version code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on your online book and projects using Python 3.5. Since I used a different and newer python version, I came across several problems and solved them by making some changes in network.py and mnist_loader files. Now the code is compatible with Python 3.5
The biggest problem is zip variables haven't len() attribute in 3.5. So I converted training_data, test_data to the list variables. I had to make a deep copy of original training and test data because when they are converted to list variables, they can't be reused.