We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apparently the hack introduced by #145 (using custom PACKAGES list for older Go versions) is not working and never worked on Windows.
Here is an example of a run which has the full list of PACKAGES on Windows:
https://github.com/moby/sys/actions/runs/10298746983/job/28504536200
You can see it works fine on other platforms (Linux and Mac OS X).
The text was updated successfully, but these errors were encountered:
@thaJeztah I'm thinking about a way to add a kludge to skip running a command if go version in package's go.mod is newer than that of go version.
go version
Sorry, something went wrong.
The alternative is to drop go 1.18 support 👯
Hm.... interesting;
So the PACKAGES env-var is ignored in the Makefile on Windows; is that a difference between Make used on Windows and Linux?
PACKAGES
Also curious why CI passed even though there's clearly some error; is that because of our use of a sub shell ((cd $p; go mod tidy);)?
(cd $p; go mod tidy);
Successfully merging a pull request may close this issue.
Apparently the hack introduced by #145 (using custom PACKAGES list for older Go versions) is not working and never worked on Windows.
Here is an example of a run which has the full list of PACKAGES on Windows:
https://github.com/moby/sys/actions/runs/10298746983/job/28504536200
You can see it works fine on other platforms (Linux and Mac OS X).
The text was updated successfully, but these errors were encountered: