Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix not honoring PACKAGES setting in gha Windows runners #157

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

kolyshkin
Copy link
Collaborator

Fixes #156.

This might fix issue 156.

Signed-off-by: Kir Kolyshkin <[email protected]>
Otherwise it's displayed using the first line of the run: argument, i.e.
like this:

> Run # This corresponds with the list in Makefile:1, but omits the "userns"

which is a bit confusing.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin requested a review from thaJeztah September 21, 2024 04:31
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 29394de into moby:main Sep 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: PACKAGES hack doesn't work on Windows
2 participants