Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added Rspamd installation #493

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

WIP: Added Rspamd installation #493

wants to merge 47 commits into from

Conversation

Spitfireap
Copy link
Member

Enabled the installation of automated Rspamd installation through the installer.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Attention: Patch coverage is 38.70968% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (715a5e3) to head (416eac9).
Report is 1 commits behind head on master.

❗ Current head 416eac9 differs from pull request most recent head e9e17ec. Consider uploading reports for the commit e9e17ec to get more accurate results

Files Patch % Lines
modoboa_installer/package.py 15.38% 11 Missing ⚠️
modoboa_installer/utils.py 46.15% 7 Missing ⚠️
run.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   54.40%   53.86%   -0.54%     
==========================================
  Files          10       10              
  Lines         761      789      +28     
==========================================
+ Hits          414      425      +11     
- Misses        347      364      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almereyda
Copy link
Contributor

Hi @Spitfireap!

I'm seeing that your contributions are also included in the latest modoboa-rspamd v1.0.0 release.

We are soon doing the switch from v1 to the v2 series, and have not the best experiences with SpamAssassin, why rspamd comes to mind. Seeing your contributions encourages me to test it out.

Would it be possible to add some documentation, e.g. to the readme, about how to set up rspamd (instead of SpamAssassin + amavis?), and maybe some notes to the modoboa-rspamd repository on how to configure and use it?

I'm interested in checking out your branch here during our upgrade, to give feedback and find quirks, but I would need some instructions on how to work myself there. Thanks in advance for any pointers!

@Spitfireap
Copy link
Member Author

Hi, thanks for your interest. The branch nor modoboa-rspamd is not ready yet for production use eventhough we use it with @tonioo and it does the work (minus some adjustments needed).

We have not developed any migration tool but a backup and restore on a fresh server might do the trick...

As for the documentation, it is not automatically deployed for now but it is nonetheless avaliable here (not quite detailed for now though).

@almereyda
Copy link
Contributor

I will follow the these developments closely. We have no ETA yet for when we will do (1) the switch to the v2 series and (2) to rspamd. Thanks for investing time and effort into this, it is much appreciated.

@almereyda
Copy link
Contributor

I'm very interested in testing this branch, esp. due to support for ARC signing in rspamd.

Unfortunately we only have a production instance available and a supported upgrade path is a sufficient condition for this integration to work. From my current knowledge, these upgrade instructions should include information about installing and setting up rspamd, as well as removing and uninstalling SpamAssassin and OpenDKIM.

Ideally this is taken care of by the installer.

At this stage of maturity of this PR, does it seem feasible that we set up a testing instance and work towards documenting this upgrade path?

@Spitfireap
Copy link
Member Author

I'm very interested in testing this branch, esp. due to support for ARC signing in rspamd.

* [ARC verification and signing for automated senders modoboa-rspamd#6](https://github.com/modoboa/modoboa-rspamd/issues/6)

Unfortunately we only have a production instance available and a supported upgrade path is a sufficient condition for this integration to work. From my current knowledge, these upgrade instructions should include information about installing and setting up rspamd, as well as removing and uninstalling SpamAssassin and OpenDKIM.

Ideally this is taken care of by the installer.

At this stage of maturity of this PR, does it seem feasible that we set up a testing instance and work towards documenting this upgrade path?

@almereyda I've added it with my latest commit on the installer by reusing the DKIM keys. I'm not sure if it's ok or not...

@Spitfireap Spitfireap marked this pull request as ready for review October 31, 2024 12:00
@almereyda
Copy link
Contributor

I can come back here during winter.

@almereyda
Copy link
Contributor

Let me see to testing this PR on a separate testing environment during the next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants