Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Fix quilt validator (#916) #2159

Fix quilt validator (#916)

Fix quilt validator (#916) #2159

Triggered via push May 9, 2024 03:28
Status Success
Total duration 3m 48s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
unnecessary use of `get(&PackFileHash::Sha512).is_none()`: src/validate/modpack.rs#L58
warning: unnecessary use of `get(&PackFileHash::Sha512).is_none()` --> src/validate/modpack.rs:58:28 | 58 | if file.hashes.get(&PackFileHash::Sha512).is_none() { | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!file.hashes.contains_key(&PackFileHash::Sha512)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
unnecessary use of `get(&PackFileHash::Sha1).is_none()`: src/validate/modpack.rs#L52
warning: unnecessary use of `get(&PackFileHash::Sha1).is_none()` --> src/validate/modpack.rs:52:28 | 52 | if file.hashes.get(&PackFileHash::Sha1).is_none() { | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!file.hashes.contains_key(&PackFileHash::Sha1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
unnecessary use of `to_string`: src/queue/moderation.rs#L365
warning: unnecessary use of `to_string` --> src/queue/moderation.rs:365:81 | 365 | ... if let Some(hash) = file.hashes.get(&"sha1".to_string()) { | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `"sha1"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: src/database/models/user_item.rs#L472
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/database/models/user_item.rs:472:72 | 472 | models::Collection::remove(collection_id, transaction, &redis).await?; | ^^^^^^ help: change this to: `redis` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead: src/database/redis.rs#L220
warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead --> src/database/redis.rs:220:24 | 220 | if Utc.timestamp(val.iat + ACTUAL_EXPIRY, 0) < current_time { | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/